[Gtk4] Fix missing space between TreeItem icon and label#3409
Merged
Conversation
Member
Author
|
Before: |
Measuring the allocation of GtkSeparator before it's realized always gives 0x0 so icon and label are really glued. Use gtk_cell_renderer_get_padding to query the cell renderer for that info. Gtk 3 could use same code but I decided to not do it as separator has bigger width than cellrenderer padding and I don't want to change Gtk 3 visual behavior (make trees more "condensed").
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measuring the allocation of GtkSeparator before it's realized always gives 0x0 so icon and label are really glued.
Use gtk_cell_renderer_get_padding to query the cell renderer for that info. Gtk 3 could use same code but I decided to not do it as separator has bigger width than cellrenderer padding and I don't want to change Gtk 3 visual behavior (make trees more "condensed").